Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: ravipesala <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-605-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-605-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #605: [CARBONDATA-715] Optimize Single-Pas...
Content-Type: text/plain
Message-Id: <20170223112849.45577DFC1C@git1-us-west.apache.org>
Date: Thu, 23 Feb 2017 11:28:49 +0000 (UTC)
archived-at: Thu, 23 Feb 2017 11:28:53 -0000

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/605#discussion_r102693310
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/generator/key/DictionaryKey.java ---
    @@ -36,17 +36,76 @@
       /**
        * message data
        */
    -  private Object data;
    +  private String data;
     
       /**
    -   * message type
    +   * Dictionary Value
        */
    -  private String type;
    +  private int dictionaryValue = -1;
    --- End diff --
    
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---