Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-584-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-584-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #584: [CARBONDATA-726] Handled query and s...
Content-Type: text/plain
Message-Id: <20170223021657.EED79DFF16@git1-us-west.apache.org>
Date: Thu, 23 Feb 2017 02:16:57 +0000 (UTC)
archived-at: Thu, 23 Feb 2017 02:17:04 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/584#discussion_r102614757
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -589,7 +591,7 @@
        * INMEMORY_REOCRD_SIZE
        */
       public static final String DETAIL_QUERY_BATCH_SIZE = "carbon.detail.batch.size";
    --- End diff --
    
    can you add comment for this parameter to describe what it controls


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---