Return-Path: <issues-return-5326-archive-asf-public=cust-asf.ponee.io@carbondata.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id D8909200C28
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 13 Feb 2017 05:03:06 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id D6D97160B6E; Mon, 13 Feb 2017 04:03:06 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 2CE3F160B6B
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 13 Feb 2017 05:03:06 +0100 (CET)
Received: (qmail 98109 invoked by uid 500); 13 Feb 2017 04:03:05 -0000
Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@carbondata.incubator.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@carbondata.incubator.apache.org>
List-Post: <mailto:issues@carbondata.incubator.apache.org>
List-Id: <issues.carbondata.incubator.apache.org>
Reply-To: dev@carbondata.incubator.apache.org
Delivered-To: mailing list issues@carbondata.incubator.apache.org
Received: (qmail 98100 invoked by uid 99); 13 Feb 2017 04:03:05 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Feb 2017 04:03:05 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id DBDCD1804C1
	for <issues@carbondata.apache.org>; Mon, 13 Feb 2017 04:03:04 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -7.019
X-Spam-Level: 
X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-2.999] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024)
	with ESMTP id UlbCtpsNSs2s for <issues@carbondata.apache.org>;
	Mon, 13 Feb 2017 04:03:04 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 55DC25F252
	for <issues@carbondata.incubator.apache.org>; Mon, 13 Feb 2017 04:03:03 +0000 (UTC)
Received: (qmail 98095 invoked by uid 99); 13 Feb 2017 04:03:02 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Feb 2017 04:03:02 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 834E9DFD73; Mon, 13 Feb 2017 04:03:02 +0000 (UTC)
From: ravipesala <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-594-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-594-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #594: [CARBONDATA-701]Fix memory leak issu...
Content-Type: text/plain
Message-Id: <20170213040302.834E9DFD73@git1-us-west.apache.org>
Date: Mon, 13 Feb 2017 04:03:02 +0000 (UTC)
archived-at: Mon, 13 Feb 2017 04:03:07 -0000

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/594#discussion_r100721427
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/sort/impl/ParallelReadMergeSorterImpl.java ---
    @@ -86,11 +88,10 @@ public void initialize(SortParameters sortParameters) {
                 sortParameters.getNoDictionaryDimnesionColumn(), sortParameters.isUseKettle());
       }
     
    -  @Override
    -  public Iterator<CarbonRowBatch>[] sort(Iterator<CarbonRowBatch>[] iterators)
    +  public void prepare(Iterator<CarbonRowBatch>[] iterators)
    --- End diff --
    
    Better change name to initialize


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---