carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #609: [CARBONDATA-726] Added code for V3 f...
Date Fri, 24 Feb 2017 03:54:29 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/609#discussion_r102875453
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
    @@ -1151,6 +1139,68 @@
     
       public static final String USE_KETTLE_DEFAULT = "false";
     
    +  /**
    +   * number of page per blocklet column
    +   */
    +  public static final String NUMBER_OF_PAGE_IN_BLOCKLET_COLUMN =
    --- End diff --
    
    all these newly added config is for V3 reader/writer, I think it is better to separte
them into a separate Constrant class


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message