carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #609: [CARBONDATA-726] Added code for V3 f...
Date Fri, 24 Feb 2017 03:50:40 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/609#discussion_r102875150
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
    @@ -835,26 +834,23 @@
       /**
        * ZOOKEEPERLOCK TYPE
        */
    -  public static final String CARBON_LOCK_TYPE_ZOOKEEPER =
    -      "ZOOKEEPERLOCK";
    +  public static final String CARBON_LOCK_TYPE_ZOOKEEPER = "ZOOKEEPERLOCK";
     
       /**
        * LOCALLOCK TYPE
        */
    -  public static final String CARBON_LOCK_TYPE_LOCAL =
    -      "LOCALLOCK";
    +  public static final String CARBON_LOCK_TYPE_LOCAL = "LOCALLOCK";
     
       /**
        * HDFSLOCK TYPE
        */
    -  public static final String CARBON_LOCK_TYPE_HDFS =
    -      "HDFSLOCK";
    +  public static final String CARBON_LOCK_TYPE_HDFS = "HDFSLOCK";
     
       /**
        * Invalid filter member log string
        */
    -  public static final String FILTER_INVALID_MEMBER = " Invalid Record(s) are present
"
    -                                                     + "while filter evaluation. ";
    +  public static final String FILTER_INVALID_MEMBER =
    +      " Invalid Record(s) are present " + "while filter evaluation. ";
    --- End diff --
    
    remove the string concatenate


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message