carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <>
Subject [GitHub] incubator-carbondata pull request #605: [CARBONDATA-715] Optimize Single-Pas...
Date Thu, 23 Feb 2017 11:25:26 GMT
Github user ravipesala commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/generator/key/
    @@ -16,12 +16,12 @@
     package org.apache.carbondata.core.dictionary.generator.key;
    +import io.netty.buffer.ByteBuf;
      * Dictionary key to generate dictionary
    -public class DictionaryKey implements Serializable {
    +public class DictionaryKey {
    --- End diff --
    Ok, but added in same object to avoid other unnecessary copying of metadata from request
to response  

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message