carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <>
Subject [GitHub] incubator-carbondata pull request #605: [CARBONDATA-715] Optimize Single-Pas...
Date Thu, 23 Feb 2017 10:25:00 GMT
Github user ravipesala commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/client/
    @@ -16,57 +16,59 @@
     package org.apache.carbondata.core.dictionary.client;
    -import java.util.Map;
     import java.util.concurrent.BlockingQueue;
    -import java.util.concurrent.ConcurrentHashMap;
     import java.util.concurrent.LinkedBlockingQueue;
     import org.apache.carbondata.common.logging.LogService;
     import org.apache.carbondata.common.logging.LogServiceFactory;
     import org.apache.carbondata.core.dictionary.generator.key.DictionaryKey;
    -import org.apache.carbondata.core.dictionary.generator.key.KryoRegister;
    +import io.netty.buffer.ByteBuf;
      * Client handler to get data.
    -public class DictionaryClientHandler extends SimpleChannelHandler {
    +public class DictionaryClientHandler extends ChannelInboundHandlerAdapter {
       private static final LogService LOGGER =
    -  final Map<String, BlockingQueue<DictionaryKey>> dictKeyQueueMap = new ConcurrentHashMap<>();
    +  final BlockingQueue<DictionaryKey> dictKeyQueue = new LinkedBlockingQueue<>();
    --- End diff --

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message