carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #584: [CARBONDATA-726] Handled query and s...
Date Thu, 23 Feb 2017 05:15:59 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/584#discussion_r102640748
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/cache/dictionary/Dictionary.java
---
    @@ -59,6 +59,17 @@
       String getDictionaryValueForKey(int surrogateKey);
     
       /**
    +   * This method will find and return the dictionary value for a given surrogate key
in bytes.
    +   * Applicable scenarios:
    +   * 1. Query final result preparation : While convert the final result which will
    +   * be surrogate key back to original dictionary values this method will be used
    --- End diff --
    
    It is added because `getDictionaryValueForKey` gets the bytes from dictionary and convert
to String, but in our decoder we again convert to bytes. So I added new method to return bytes
directly with out converting to String to avoid multiple conversions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message