carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anubhav100 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #607: [CARBONDATA-712]resolve the bug for ...
Date Thu, 23 Feb 2017 02:42:03 GMT
Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/607#discussion_r102628013
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/BadRecordsLogger.java
---
    @@ -176,15 +176,13 @@ private synchronized void writeBadRecordsToFile(StringBuilder logStrings)
{
     
             bufferedWriter = new BufferedWriter(new OutputStreamWriter(outStream,
                 Charset.forName(CarbonCommonConstants.DEFAULT_CHARSET)));
    -
           }
           bufferedWriter.write(logStrings.toString());
    -      bufferedWriter.flush();
           bufferedWriter.newLine();
         } catch (FileNotFoundException e) {
           LOGGER.error("Bad Log Files not found");
         } catch (IOException e) {
    -      LOGGER.error("Error While writing bad log File");
    +      LOGGER.error("Error While writ1ing bad log File");
    --- End diff --
    
    @chenliang613 i corrected it you can review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message