carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #584: [CARBONDATA-726] Handled query and s...
Date Thu, 23 Feb 2017 02:16:57 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/584#discussion_r102622345
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/measure/v1/CompressedMeasureChunkFileBasedReaderV1.java
---
    @@ -77,20 +79,38 @@ public CompressedMeasureChunkFileBasedReaderV1(final BlockletInfo
blockletInfo,
        * @param blockIndex block to be read
        * @return measure data chunk
        */
    -  @Override public MeasureColumnDataChunk readMeasureChunk(final FileHolder fileReader,
    -      final int blockIndex) throws IOException {
    +  @Override public MeasureRawColumnChunk readRawMeasureChunk(FileHolder fileReader, int
blockIndex)
    +      throws IOException {
    +    ByteBuffer buffer =
    +        ByteBuffer.allocateDirect(measureColumnChunks.get(blockIndex).getDataPageLength());
    --- End diff --
    
    assign `measureColumnChunks.get(blockIndex)` to a local variable and use it in this function


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message