carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #584: [CARBONDATA-726] Handled query and s...
Date Thu, 23 Feb 2017 02:16:57 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/584#discussion_r102624180
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RestructureFilterExecuterImpl.java
---
    @@ -35,18 +37,18 @@ public RestructureFilterExecuterImpl(DimColumnResolvedFilterInfo dimColumnResolv
                 dimColumnResolvedFilterInfo.getDimension(), dimColumnExecuterInfo);
       }
     
    -  @Override public BitSet applyFilter(BlocksChunkHolder blocksChunkHolder) {
    -    BitSet bitSet = new BitSet(blocksChunkHolder.getDataBlock().nodeSize());
    -    byte[][] filterValues = dimColumnExecuterInfo.getFilterKeys();
    -    if (null != filterValues && filterValues.length > 0) {
    -      bitSet.set(0, blocksChunkHolder.getDataBlock().nodeSize());
    -    }
    -    return bitSet;
    +  @Override public BitSetGroup applyFilter(BlocksChunkHolder blocksChunkHolder) {
    +    // TODO find out what is this for?
    +    return new BitSetGroup(0);
       }
     
       @Override public BitSet isScanRequired(byte[][] blockMaxValue, byte[][] blockMinValue)
{
         BitSet bitSet = new BitSet(1);
         bitSet.set(0);
         return bitSet;
       }
    +
    +  @Override public void readBlocks(BlocksChunkHolder blockChunkHolder) throws IOException
{
    +    // TODO
    --- End diff --
    
    Throw UnSupportedOperationException instead of this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message