carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #584: [CARBONDATA-726] Handled query and s...
Date Thu, 23 Feb 2017 02:16:57 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/584#discussion_r102614395
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/cache/dictionary/Dictionary.java
---
    @@ -59,6 +59,17 @@
       String getDictionaryValueForKey(int surrogateKey);
     
       /**
    +   * This method will find and return the dictionary value for a given surrogate key
in bytes.
    +   * Applicable scenarios:
    +   * 1. Query final result preparation : While convert the final result which will
    +   * be surrogate key back to original dictionary values this method will be used
    --- End diff --
    
     Can you add description why this function will be called instead of `getDictionaryValueForKey`
to depict why this is needed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message