carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #606: [CARBONDATA-713] Make the store path...
Date Wed, 22 Feb 2017 02:41:20 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/606#discussion_r102372504
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/util/FileUtils.scala
---
    @@ -91,4 +94,24 @@ object FileUtils {
         }
       }
     
    +  /*
    +   * The store location of carbon comes from three places:
    +   * 1. default location path in code(../carbon.store)
    +   * 2. configurate "carbon.storelocation" in carbon.properties
    +   * 3. pass the location as the parameter
    +   * The priority is low to high.
    +   */
    +  def getHighestPriorityStorePath(storePathParameter: String): String = {
    +    val storePathDefaultValue =
    +      new File(CarbonCommonConstants.STORE_LOCATION_DEFAULT_VAL).getCanonicalPath
    +    val storePathProperties = CarbonProperties.getInstance()
    +      .getProperty(CarbonCommonConstants.STORE_LOCATION)
    +    if (!storePathParameter.equals(storePathDefaultValue)) {
    --- End diff --
    
    I think user can still use `val cc = new CarbonContext(sc)`, so API will not change
    @ravipesala what is your opinion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message