carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #605: [CARBONDATA-715] Optimize Single-Pas...
Date Wed, 22 Feb 2017 01:27:42 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/605#discussion_r102363987
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/server/DictionaryServer.java
---
    @@ -83,9 +81,12 @@ public ChannelPipeline getPipeline() throws Exception {
        */
       public void shutdown() throws Exception {
         DictionaryKey key = new DictionaryKey();
    -    key.setType("WRITE_DICTIONARY");
    +    key.setType(DictionaryKeyType.WRITE_DICTIONARY);
         dictionaryServerHandler.processMessage(key);
    -    bootstrap.releaseExternalResources();
    -    bootstrap.shutdown();
    +    worker.shutdownGracefully();
    --- End diff --
    
    How about using bootstrap to shut it down?
    ```
        long startTime = System.currentTimeMillis();
        if (bindFuture != null) {
          bindFuture.channel().close().awaitUninterruptibly();
          bindFuture = null;
        }
    
        if (bootstrap != null) {
          if (bootstrap.group() != null) {
            bootstrap.group().shutdownGracefully();
          }
          bootstrap = null;
        }
        long endTime = System.currentTimeMillis();
        LOGGER.info("Dictionary Server shutdown! Time spent " + (endTime - startTime));
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message