carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #605: [CARBONDATA-715] Optimize Single-Pas...
Date Wed, 22 Feb 2017 00:56:09 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/605#discussion_r102359538
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClientHandler.java
---
    @@ -16,57 +16,59 @@
      */
     package org.apache.carbondata.core.dictionary.client;
     
    -import java.util.Map;
     import java.util.concurrent.BlockingQueue;
    -import java.util.concurrent.ConcurrentHashMap;
     import java.util.concurrent.LinkedBlockingQueue;
     
     import org.apache.carbondata.common.logging.LogService;
     import org.apache.carbondata.common.logging.LogServiceFactory;
     import org.apache.carbondata.core.dictionary.generator.key.DictionaryKey;
    -import org.apache.carbondata.core.dictionary.generator.key.KryoRegister;
     
    -import org.jboss.netty.channel.ChannelHandlerContext;
    -import org.jboss.netty.channel.ChannelStateEvent;
    -import org.jboss.netty.channel.ExceptionEvent;
    -import org.jboss.netty.channel.MessageEvent;
    -import org.jboss.netty.channel.SimpleChannelHandler;
    +import io.netty.buffer.ByteBuf;
    +import io.netty.channel.ChannelHandlerContext;
    +import io.netty.channel.ChannelInboundHandlerAdapter;
     
     /**
      * Client handler to get data.
      */
    -public class DictionaryClientHandler extends SimpleChannelHandler {
    +public class DictionaryClientHandler extends ChannelInboundHandlerAdapter {
     
       private static final LogService LOGGER =
               LogServiceFactory.getLogService(DictionaryClientHandler.class.getName());
     
    -  final Map<String, BlockingQueue<DictionaryKey>> dictKeyQueueMap = new ConcurrentHashMap<>();
    +  final BlockingQueue<DictionaryKey> dictKeyQueue = new LinkedBlockingQueue<>();
    --- End diff --
    
    suggest to change to responseMsgQueue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message