carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #607: [CARBONDATA-712]resolve the bug for ...
Date Tue, 21 Feb 2017 07:22:53 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/607#discussion_r102144509
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/BadRecordsLogger.java
---
    @@ -179,6 +179,7 @@ private synchronized void writeBadRecordsToFile(StringBuilder logStrings)
{
     
           }
           bufferedWriter.write(logStrings.toString());
    +      bufferedWriter.flush();
    --- End diff --
    
    It is not the correct way, please don't flush for every row. it slows down a lot.
     Please close the streams properly, it will solve the problem


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message