carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #597: [CARBONDATA-672]complex data type su...
Date Wed, 15 Feb 2017 10:05:55 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/597#discussion_r101241648
  
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala
---
    @@ -193,15 +194,21 @@ case class CarbonDictionaryDecoder(
                   }
                   flag
                 }
    +
                 override final def next(): InternalRow = {
                   val startTime = System.currentTimeMillis()
                   val row: InternalRow = iter.next()
                   val data = row.toSeq(dataTypes).toArray
                   dictIndex.foreach { index =>
                     if (data(index) != null) {
    -                  data(index) = DataTypeUtil.getDataBasedOnDataType(dicts(index)
    -                    .getDictionaryValueForKey(data(index).asInstanceOf[Int]),
    -                    getDictionaryColumnIds(index)._3)
    +                  try {
    +                    data(index) = DataTypeUtil.getDataBasedOnDataType(dicts(index)
    --- End diff --
    
    Please just add  `!carbonDimension.isComplex()` in line number 63 and 132. That should
solve the problem, remove all other unnecessary excepion handlings



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message