carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #594: [CARBONDATA-701]Fix memory leak issu...
Date Mon, 13 Feb 2017 04:09:10 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/594#discussion_r100721771
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/IntermediateFileMerger.java
---
    @@ -116,8 +116,15 @@ public IntermediateFileMerger(SortParameters mergerParameters, File[]
intermedia
               writeDataTofile(next());
             }
           } else {
    +        int i = 0;
             while (hasNext()) {
    +          i++;
               writeDataTofileWithOutKettle(next());
    +          if (i % 10000 == 0) {
    --- End diff --
    
    it is unnecessary calculation we are adding in it. Already the buffer size is configurable
so once buffer size reaches buffered out stream can flush it down.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message