Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: ravikiran23 <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-523-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-523-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #523: [CARBONDATA-440] fixing no kettle is...
Content-Type: text/plain
Message-Id: <20170116062059.816AEDFBDC@git1-us-west.apache.org>
Date: Mon, 16 Jan 2017 06:20:59 +0000 (UTC)
archived-at: Mon, 16 Jan 2017 06:21:04 -0000

Github user ravikiran23 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/523#discussion_r96169571
  
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ---
    @@ -719,16 +720,50 @@ object CarbonDataRDDFactory {
                   loadMetadataDetails.setLoadStatus(CarbonCommonConstants.STORE_LOADSTATUS_SUCCESS)
                   val rddIteratorKey = CarbonCommonConstants.RDDUTIL_UPDATE_KEY +
                                        UUID.randomUUID().toString
    +              if (useKettle) {
    +                try {
    +                  RddInpututilsForUpdate.put(rddIteratorKey,
    +                    new RddIteratorForUpdate(iter, carbonLoadModel))
    +                  carbonLoadModel.setRddIteratorKey(rddIteratorKey)
    +                  CarbonDataLoadForUpdate
    +                    .run(carbonLoadModel, index, storePath, kettleHomePath,
    +                      segId, loadMetadataDetails, executionErrors)
    +                } finally {
    +                  RddInpututilsForUpdate.remove(rddIteratorKey)
    +                }
    +              } else {
    +                try {
    +                  val recordReaders = mutable.Buffer[CarbonIterator[Array[AnyRef]]]()
    +                  val serializer = SparkEnv.get.closureSerializer.newInstance()
    +                  var serializeBuffer: ByteBuffer = null
    +                    recordReaders += new CarbonIteratorImpl(
    +                      new NewRddIterator(iter,
    +                        carbonLoadModel,
    +                        TaskContext.get()))
    +
    +                  val loader = new SparkPartitionLoader(carbonLoadModel,
    +                    index,
    +                    null,
    +                    null,
    +                    segId,
    +                    loadMetadataDetails)
    +                  // Intialize to set carbon properties
    +                  loader.initialize()
    +
    +                  loadMetadataDetails.setLoadStatus(CarbonCommonConstants.STORE_LOADSTATUS_SUCCESS)
    +                  new DataLoadExecutor()
    +                    .execute(carbonLoadModel, loader.storeLocation, recordReaders.toArray)
    --- End diff --
    
    fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---