Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DDCEC200BF8 for ; Fri, 13 Jan 2017 16:52:31 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DC936160B3F; Fri, 13 Jan 2017 15:52:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2FC05160B32 for ; Fri, 13 Jan 2017 16:52:31 +0100 (CET) Received: (qmail 36362 invoked by uid 500); 13 Jan 2017 15:52:30 -0000 Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.incubator.apache.org Delivered-To: mailing list issues@carbondata.incubator.apache.org Received: (qmail 36353 invoked by uid 99); 13 Jan 2017 15:52:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jan 2017 15:52:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id F0AA6185F4D for ; Fri, 13 Jan 2017 15:52:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id usAqK7mtrxgu for ; Fri, 13 Jan 2017 15:52:29 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 46C925FBE1 for ; Fri, 13 Jan 2017 15:52:28 +0000 (UTC) Received: (qmail 35971 invoked by uid 99); 13 Jan 2017 15:52:26 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jan 2017 15:52:26 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 7D514DFADF; Fri, 13 Jan 2017 15:52:26 +0000 (UTC) From: anubhav100 To: issues@carbondata.incubator.apache.org Reply-To: issues@carbondata.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-carbondata pull request #511: [CARBONDATA-584]added validation for... Content-Type: text/plain Message-Id: <20170113155226.7D514DFADF@git1-us-west.apache.org> Date: Fri, 13 Jan 2017 15:52:26 +0000 (UTC) archived-at: Fri, 13 Jan 2017 15:52:32 -0000 Github user anubhav100 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/511#discussion_r96021165 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala --- @@ -108,6 +110,10 @@ class CarbonSource extends CreatableRelationProvider val dbName: String = parameters.getOrElse("dbName", CarbonCommonConstants.DATABASE_DEFAULT_NAME) val tableName: String = parameters.getOrElse("tableName", "default_table") + if(org.apache.commons.lang.StringUtils.isBlank(tableName) || + org.apache.commons.lang.StringUtils.isWhitespace(tableName)) { + throw new MalformedCarbonCommandException("INVALID TABLE NAME") --- End diff -- @jackylk i think emptyTableName will make less sense because it is not gurranted that it will be empty --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---