Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: kumarvishal09 <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-450-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-450-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #450: [CARBONDATA-545]Added support for of...
Content-Type: text/plain
Message-Id: <20170105142440.E90B1DF9F9@git1-us-west.apache.org>
Date: Thu,  5 Jan 2017 14:24:40 +0000 (UTC)
archived-at: Thu, 05 Jan 2017 14:25:03 -0000

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/450#discussion_r94775294
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/datastore/chunk/store/impl/ByteMeasureChunkStore.java ---
    @@ -0,0 +1,56 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.core.carbon.datastore.chunk.store.impl;
    +
    +import org.apache.carbondata.core.memory.MemoryAllocatorFactory;
    +import org.apache.carbondata.core.unsafe.CarbonUnsafe;
    +
    +/**
    + * Responsible for storing Byte array data to memory.
    + * memory can be on heap or offheap based on the user configuration
    + */
    +public class ByteMeasureChunkStore extends AbstractMeasureDataChunkStore<byte[]> {
    +
    +  public ByteMeasureChunkStore(int numberOfRows) {
    +    super(numberOfRows);
    +  }
    +
    +  /**
    +   * Below method will be used to put byte array data to memory
    +   *
    +   * @param data
    +   */
    +  @Override public void putData(byte[] data) {
    +    this.dataPageMemoryBlock =
    +        MemoryAllocatorFactory.INSATANCE.getMemoryAllocator().allocate(data.length);
    --- End diff --
    
    I will add assert to check the same, thanks for pointing this out


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---