Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: gvramana <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-454-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-454-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #454: [CARBONDATA-484] Implement LRU cache...
Content-Type: text/plain
Message-Id: <20170103172335.561EBDFADE@git1-us-west.apache.org>
Date: Tue,  3 Jan 2017 17:23:35 +0000 (UTC)
archived-at: Tue, 03 Jan 2017 17:23:41 -0000

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/454#discussion_r94445029
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CacheClient.java ---
    @@ -0,0 +1,96 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.carbondata.hadoop;
    +
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +import org.apache.carbondata.core.cache.CacheProvider;
    +import org.apache.carbondata.core.cache.CacheType;
    +import org.apache.carbondata.core.carbon.AbsoluteTableIdentifier;
    +import org.apache.carbondata.core.carbon.datastore.SegmentTaskIndexStore;
    +import org.apache.carbondata.core.carbon.datastore.TableSegmentUniqueIdentifier;
    +import org.apache.carbondata.core.carbon.datastore.block.SegmentTaskIndexWrapper;
    +import org.apache.carbondata.core.constants.CarbonCommonConstants;
    +import org.apache.carbondata.core.util.CarbonUtilException;
    +
    +/**
    + * CacheClient : Class used to request the segments cache
    + */
    +public class CacheClient {
    +  /**
    +   * List of segments
    +   */
    +  private List<TableSegmentUniqueIdentifier> segmentList =
    +      new ArrayList<>(CarbonCommonConstants.DEFAULT_COLLECTION_SIZE);
    +
    +  /**
    +   * absolute table identifier
    +   */
    +  private AbsoluteTableIdentifier absoluteTableIdentifier;
    +
    +  private SegmentTaskIndexStore segmentCache;
    +
    +  /**
    +   * @param absoluteTableIdentifier
    +   */
    +  public CacheClient(AbsoluteTableIdentifier absoluteTableIdentifier) {
    +    this.absoluteTableIdentifier = absoluteTableIdentifier;
    +    segmentCache = (SegmentTaskIndexStore) CacheProvider.getInstance()
    +        .createCache(CacheType.DRIVER_BTREE, absoluteTableIdentifier.getStorePath());
    +  }
    +
    +  /**
    +   * The method returns the SegmentTaskIndexWrapper from the segments cache
    +   *
    +   * @param tableSegmentUniqueIdentifier
    +   * @return
    +   * @throws CarbonUtilException
    +   */
    +  public SegmentTaskIndexWrapper getSegmentTaskIndexWrapper(
    --- End diff --
    
    CacheClient should have specific logic , it should just be responsible for bookkeeping of objects being accessed.
    Move this logic back to CarbonInputFormat and add getIfPresent and get methods to CacheClient


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---