carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #569: [WIP]Fixed GC issue and re-factor di...
Date Thu, 26 Jan 2017 13:40:45 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/569#discussion_r97994548
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
---
    @@ -129,19 +203,20 @@ public DictionaryBasedResultCollector(BlockExecutionInfo blockExecutionInfos)
{
                       .getDataBasedOnDataType(noDictionaryKeys[noDictionaryColumnIndex++],
                           queryDimensions[i].getDimension().getDataType());
                 }
    -          } else if (directDictionaryEncodingArray[i]) {
    -            DirectDictionaryGenerator directDictionaryGenerator =
    -                DirectDictionaryKeyGeneratorFactory
    -                    .getDirectDictionaryGenerator(queryDimensions[i].getDimension().getDataType());
    -            if (directDictionaryGenerator != null) {
    -              row[order[i]] = directDictionaryGenerator.getValueFromSurrogate(
    +          } else if (directDictionaryEncodingArray[i] == 1
    +              || directDictionaryEncodingArray[i] == 2) {
    +            if (directDictionaryEncodingArray[i] == 1) {
    --- End diff --
    
    this if check can be merged into last one


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message