carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JihongMA <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #554: [CARBONDATA-661] misc cleanup in car...
Date Mon, 23 Jan 2017 20:10:15 GMT
Github user JihongMA commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/554#discussion_r97404648
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/keygenerator/columnar/impl/MultiDimKeyVarLengthEquiSplitGenerator.java
---
    @@ -143,17 +142,18 @@ private void intialize() {
     
       private int[] convertToArray(List<Integer> list) {
    --- End diff --
    
    the whole purpose of this function is to unbox Integer array into integer array, not converting
List[Integer] to Integer[]. 
    
     I looked closely at the caller of the function initialize(), which can be rewritten to
avoid this back and forth set/list/array conversion.  and can be addressed in a separate PR.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message