carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenliang613 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #557: [WIP] Set carbon properties location...
Date Fri, 20 Jan 2017 06:52:19 GMT
Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/557#discussion_r97020867
  
    --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala
---
    @@ -39,14 +42,15 @@ object CarbonThriftServer {
     
         val sparkHome = System.getenv.get("SPARK_HOME")
         if (null != sparkHome) {
    -      builder.config("carbon.properties.filepath",
    -        sparkHome + '/' + "conf" + '/' + "carbon.properties")
    -      System.setProperty("carbon.properties.filepath",
    -        sparkHome + '/' + "conf" + '/' + "carbon.properties")
    +      val file = new File(sparkHome + '/' + "conf" + '/' + "carbon.properties")
    +      if (file.exists()) {
    +        builder.config("carbon.properties.filepath", file.getCanonicalPath)
    +        System.setProperty("carbon.properties.filepath", file.getCanonicalPath)
    +      }
         }
    -    CarbonProperties.getInstance().addProperty("carbon.storelocation", args.head)
    +    CarbonProperties.getInstance().addProperty(CarbonCommonConstants.STORE_LOCATION,
args.head)
     
    --- End diff --
    
    CarbonCommonConstants.STORE_LOCATION also get value from carbon.properties.carbon.storelocation,
why need do this change ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message