carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #554: [CARBONDATA-661] misc cleanup in car...
Date Thu, 19 Jan 2017 23:38:12 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/554#discussion_r96984537
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/keygenerator/columnar/impl/MultiDimKeyVarLengthEquiSplitGenerator.java
---
    @@ -143,17 +142,18 @@ private void intialize() {
     
       private int[] convertToArray(List<Integer> list) {
    --- End diff --
    
    After second thought, I think these kind of functions are unnecessary, we should use
    ```
        List<Integer> list = new LinkedList<>();
        Integer[] array = x.toArray(new Integer[list.size()]);
    ```
    from JDK instead of writing our own code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message