carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #551: [CARBONDATA-603] Fixed Date Filter i...
Date Thu, 19 Jan 2017 15:34:29 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/551#discussion_r96885076
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/ExpressionResult.java
---
    @@ -523,9 +531,17 @@ public boolean isNull() {
               return val1.compareTo(val2);
             case DATE:
             case TIMESTAMP:
    -          SimpleDateFormat parser = new SimpleDateFormat(CarbonProperties.getInstance()
    -              .getProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT,
    -                  CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT));
    +          String format= null;
    +          if(dataType==DataType.DATE) {
    --- End diff --
    
    instead of using if else, please use inside case and use break;


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message