carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #552: [CARBONDATA-661] misc cleanup in cor...
Date Thu, 19 Jan 2017 02:33:04 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/552#discussion_r96781406
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/keygenerator/columnar/impl/MultiDimKeyVarLengthEquiSplitGenerator.java
---
    @@ -143,17 +142,18 @@ private void intialize() {
     
       private int[] convertToArray(List<Integer> list) {
         int[] ints = new int[list.size()];
    -    for (int i = 0; i < ints.length; i++) {
    -      ints[i] = list.get(i);
    +    int i = 0;
    +    for (Integer ii : list) {
    --- End diff --
    
    foreach style for loop is not encouraged to use because of performance


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message