carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #546: [CARBONDATA-655][CARBONDATA-604]Make...
Date Wed, 18 Jan 2017 14:10:35 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/546#discussion_r96641464
  
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
    @@ -390,11 +390,19 @@ case class LoadTable(
           val useKettle = options.get("use_kettle") match {
             case Some(value) => value.toBoolean
             case _ =>
    -          val useKettleLocal = System.getProperty("use.kettle")
    +          var useKettleLocal = System.getProperty("use.kettle")
    +          if (useKettleLocal == null && sqlContext.sparkContext.getConf.contains("use_kettle"))
{
    --- End diff --
    
    It is strange that "use.kettle", "use_kettle", and "useKettle" are all different, can
we use the same name for all  these  configuration?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message