carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mohammadshahidkhan <>
Subject [GitHub] incubator-carbondata pull request #541: [CARBONDATA-641]supported date type ...
Date Mon, 16 Jan 2017 12:08:35 GMT
Github user mohammadshahidkhan commented on a diff in the pull request:
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
    @@ -590,7 +590,7 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser
        * detects whether double or decimal column is part of dictionary_exclude
       def isStringAndTimestampColDictionaryExclude(columnDataType: String): Boolean = {
    -    val dataTypes = Array("string", "timestamp")
    +    val dataTypes = Array("string", "timestamp", "date")
    --- End diff --
    @anubhav100 Please check my jira comment
    this is wrong you should not allow adding timestamp and date in dictionary_exclude

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message