carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #511: [CARBONDATA-584]added validation for...
Date Sat, 14 Jan 2017 04:28:42 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/511#discussion_r96108584
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
    @@ -104,14 +106,17 @@ class CarbonSource extends CreatableRelationProvider
       }
     
       private def createTableIfNotExists(sparkSession: SparkSession, parameters: Map[String,
String],
    -                                     dataSchema: StructType): String = {
    +      dataSchema: StructType): String = {
     
         val dbName: String = parameters.getOrElse("dbName", CarbonCommonConstants.DATABASE_DEFAULT_NAME)
    -    val tableName: String = parameters.getOrElse("tableName", "default_table")
    +    val emptyTableName: String = parameters.getOrElse("tableName", "default_table")
    +    if (StringUtils.isBlank(emptyTableName)) {
    +      throw new MalformedCarbonCommandException("INVALID TABLE NAME")
    --- End diff --
    
    I think there is misunderstanding, I suggest to give "the specified table name is blank"
in the exception message. Not suggesting to change the variable name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message