carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anubhav100 <>
Subject [GitHub] incubator-carbondata pull request #511: [CARBONDATA-584]added validation for...
Date Fri, 13 Jan 2017 15:52:26 GMT
Github user anubhav100 commented on a diff in the pull request:
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
    @@ -108,6 +110,10 @@ class CarbonSource extends CreatableRelationProvider
         val dbName: String = parameters.getOrElse("dbName", CarbonCommonConstants.DATABASE_DEFAULT_NAME)
         val tableName: String = parameters.getOrElse("tableName", "default_table")
    +    if(org.apache.commons.lang.StringUtils.isBlank(tableName) ||
    +       org.apache.commons.lang.StringUtils.isWhitespace(tableName)) {
    +      throw new MalformedCarbonCommandException("INVALID TABLE NAME")
    --- End diff --
    @jackylk  i think emptyTableName will make less sense because it is not gurranted that
it will be empty

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message