carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #533: [CARBONDATA-633]Fixed offheap Query ...
Date Fri, 13 Jan 2017 14:20:49 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/533#discussion_r96003271
  
    --- Diff: core/src/main/java/org/apache/carbondata/scan/executor/impl/AbstractQueryExecutor.java
---
    @@ -470,6 +477,7 @@ private AggregatorInfo getAggregatorInfoForBlock(QueryModel queryModel,
        */
       @Override public void finish() throws QueryExecutionException {
         CarbonUtil.clearBlockCache(queryProperties.dataBlocks);
    +    queryIterator.close();
    --- End diff --
    
    queryIterator is assigned in subclass?
    better to add a if check here for null value


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message