carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gvramana <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #264: [CARBONDATA-341] CarbonTableIdentifi...
Date Fri, 13 Jan 2017 09:15:21 GMT
Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/264#discussion_r95140944
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
    @@ -188,13 +194,26 @@ public static void setSegmentsToAccess(Configuration configuration,
List<String>
             .set(CarbonInputFormat.INPUT_SEGMENT_NUMBERS, CarbonUtil.getSegmentString(validSegments));
       }
     
    -  private static AbsoluteTableIdentifier getAbsoluteTableIdentifier(Configuration configuration)
{
    -    String dirs = configuration.get(INPUT_DIR, "");
    -    String[] inputPaths = StringUtils.split(dirs);
    -    if (inputPaths.length == 0) {
    -      throw new InvalidPathException("No input paths specified in job");
    +  private static AbsoluteTableIdentifier getAbsoluteTableIdentifier(Configuration configuration)
    +      throws IOException {
    +    CarbonTable carbonTable;
    +    String carbonTableStr = configuration.get(CARBON_TABLE);
    +    if (null == carbonTableStr) {
    --- End diff --
    
    divide functions as below.
    > populateCarbonTable
    > getCarbonTable will get and request populateCarbonTable if it doesnot exist in configuration
    > getAbsoluteTableIdentifier gets from getCarbonTable.getAbsoluteTableIdentifier.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message