carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #523: [CARBONDATA-440] fixing no kettle is...
Date Fri, 13 Jan 2017 01:09:02 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/523#discussion_r95920765
  
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
    @@ -719,16 +720,50 @@ object CarbonDataRDDFactory {
                   loadMetadataDetails.setLoadStatus(CarbonCommonConstants.STORE_LOADSTATUS_SUCCESS)
                   val rddIteratorKey = CarbonCommonConstants.RDDUTIL_UPDATE_KEY +
                                        UUID.randomUUID().toString
    +              if (useKettle) {
    +                try {
    +                  RddInpututilsForUpdate.put(rddIteratorKey,
    +                    new RddIteratorForUpdate(iter, carbonLoadModel))
    +                  carbonLoadModel.setRddIteratorKey(rddIteratorKey)
    +                  CarbonDataLoadForUpdate
    +                    .run(carbonLoadModel, index, storePath, kettleHomePath,
    +                      segId, loadMetadataDetails, executionErrors)
    +                } finally {
    +                  RddInpututilsForUpdate.remove(rddIteratorKey)
    +                }
    +              } else {
    +                try {
    +                  val recordReaders = mutable.Buffer[CarbonIterator[Array[AnyRef]]]()
    +                  val serializer = SparkEnv.get.closureSerializer.newInstance()
    +                  var serializeBuffer: ByteBuffer = null
    +                    recordReaders += new CarbonIteratorImpl(
    +                      new NewRddIterator(iter,
    +                        carbonLoadModel,
    +                        TaskContext.get()))
    +
    +                  val loader = new SparkPartitionLoader(carbonLoadModel,
    +                    index,
    +                    null,
    +                    null,
    +                    segId,
    +                    loadMetadataDetails)
    +                  // Intialize to set carbon properties
    +                  loader.initialize()
    +
    +                  loadMetadataDetails.setLoadStatus(CarbonCommonConstants.STORE_LOADSTATUS_SUCCESS)
    +                  new DataLoadExecutor()
    +                    .execute(carbonLoadModel, loader.storeLocation, recordReaders.toArray)
    --- End diff --
    
    move to previous line, break the line at parameter list


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message