carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #512: [CARBONDATA-582]added validation for...
Date Wed, 11 Jan 2017 07:42:37 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/512#discussion_r95525006
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
---
    @@ -138,7 +138,13 @@ class CarbonSqlAstBuilder(conf: SQLConf) extends SparkSqlAstBuilder(conf)
{
           val options = new CarbonOption(properties)
           val bucketFields = {
             if (options.isBucketingEnabled) {
    -          Some(BucketFields(options.bucketColumns.split(","), options.bucketNumber))
    +          if (options.bucketNumber.toString.contains("-") ||
    +             options.bucketNumber.toString.contains("+")) {
    +            throw new MalformedCarbonCommandException("INVALID NUMBER OF BUCKETS SPECIFIED")
    +          }
    +            else {
    --- End diff --
    
    move to previous line


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message