carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #504: [CARBONDATA-606] Add Flink example t...
Date Mon, 09 Jan 2017 01:35:52 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/504#discussion_r95095272
  
    --- Diff: examples/spark/src/main/scala/org/apache/carbondata/examples/DatasourceExample.scala
---
    @@ -37,5 +37,8 @@ object DatasourceExample {
             | OPTIONS (path '${cc.storePath}/default/table1')
           """.stripMargin)
         sqlContext.sql("SELECT c1, c2, count(*) FROM source WHERE c3 > 100 GROUP BY c1,
c2").show
    +
    +    // delete carbondata file
    +    ExampleUtils.cleanSampleCarbonFile(cc, "table1")
    --- End diff --
    
    Because this table is created by ExampleUtils, so it is more reasonable ExampleUtils expose
function to delete it instead of the caller does


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message