carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #504: [CARBONDATA-606] Add Flink example t...
Date Mon, 09 Jan 2017 01:29:58 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/504#discussion_r95095010
  
    --- Diff: examples/spark/src/main/scala/org/apache/carbondata/examples/util/ExampleUtils.scala
---
    @@ -81,15 +85,6 @@ object ExampleUtils {
             .map(x => ("a", "b", x))
             .toDF("c1", "c2", "c3")
     
    -    // save dataframe to carbon file:(df->csv->carbon file)
    -    df.write
    -        .format("carbondata")
    -        .option("tableName", tableName)
    -        .option("compress", "true")
    --- End diff --
    
    This function is supposed to write only once. It is also used in `appendSampleCarbonFile`,
if this function writes twice, it is wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message