carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mohammadshahidkhan <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #492: [CARBONDATA-440] Providing the updat...
Date Fri, 06 Jan 2017 13:12:56 GMT
Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/492#discussion_r94943478
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/datastore/SegmentTaskIndexStore.java
---
    @@ -82,23 +85,24 @@ public SegmentTaskIndexStore(String carbonStorePath, CarbonLRUCache
lruCache) {
       @Override
       public SegmentTaskIndexWrapper get(TableSegmentUniqueIdentifier tableSegmentUniqueIdentifier)
           throws IOException {
    -    SegmentTaskIndexWrapper segmentTaskIndexWrapper =
    -        loadAndGetTaskIdToSegmentsMap(tableSegmentUniqueIdentifier.getSegmentToTableBlocksInfos(),
    -            tableSegmentUniqueIdentifier.getAbsoluteTableIdentifier(),
    -            tableSegmentUniqueIdentifier);
    +    SegmentTaskIndexWrapper segmentTaskIndexWrapper = null;
    +    try {
    +      segmentTaskIndexWrapper =
    +          loadAndGetTaskIdToSegmentsMap(tableSegmentUniqueIdentifier.getSegmentToTableBlocksInfos(),
    +              tableSegmentUniqueIdentifier.getAbsoluteTableIdentifier(),
    +              tableSegmentUniqueIdentifier);
    +    } catch (IndexBuilderException e) {
    +      throw new IOException(e.getMessage(), e);
    +    } catch (Throwable e) {
    +      throw new IOException("Problem in loading segment block.", e);
    +    }
    +
         if (null != segmentTaskIndexWrapper) {
           segmentTaskIndexWrapper.incrementAccessCount();
    --- End diff --
    
    Please remove the segmentTaskIndexWrapper.incrementAccessCount();
    It is not needed here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message