carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #492: [CARBONDATA-440] Providing the updat...
Date Fri, 06 Jan 2017 12:10:56 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/492#discussion_r94937615
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/datastore/TableSegmentUniqueIdentifier.java
---
    @@ -101,10 +102,17 @@ public String getSegmentId() {
        */
       public String getUniqueTableSegmentIdentifier() {
         CarbonTableIdentifier carbonTableIdentifier =
    -        absoluteTableIdentifier.getCarbonTableIdentifier();
    -    return carbonTableIdentifier.getDatabaseName()
    -        + CarbonCommonConstants.FILE_SEPARATOR + carbonTableIdentifier
    -        .getTableId() + CarbonCommonConstants.FILE_SEPARATOR + segmentId;
    +            absoluteTableIdentifier.getCarbonTableIdentifier();
    +    return carbonTableIdentifier.getDatabaseName() + CarbonCommonConstants.FILE_SEPARATOR
    +            + carbonTableIdentifier.getTableName() + CarbonCommonConstants.UNDERSCORE
    +            + carbonTableIdentifier.getTableId() + CarbonCommonConstants.FILE_SEPARATOR
+ segmentId;
    --- End diff --
    
    As each tableId will be unique I think we can shorten the lruCacheKey and modify the code
as below.
    return carbonTableIdentifier.getTableId() + CarbonCommonConstants.FILE_SEPARATOR + segmentId;


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message