carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #492: [CARBONDATA-440] Providing the updat...
Date Fri, 06 Jan 2017 12:04:11 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/492#discussion_r94937003
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/datastore/SegmentTaskIndexStore.java
---
    @@ -185,15 +210,25 @@ private SegmentTaskIndexWrapper loadAndGetTaskIdToSegmentsMap(
               // acquire lock to lod the segment
               synchronized (segmentLoderLockObject) {
                 segmentTaskIndexWrapper = (SegmentTaskIndexWrapper) lruCache.get(lruCacheKey);
    -            if (null == segmentTaskIndexWrapper) {
    -              // creating a map of take if to table segment
    -              taskIdToSegmentIndexMap = new HashMap<TaskBucketHolder, AbstractIndex>();
    -              segmentTaskIndexWrapper = new SegmentTaskIndexWrapper(taskIdToSegmentIndexMap);
    +            if (null == segmentTaskIndexWrapper || tableSegmentUniqueIdentifier
    +                .isSegmentUpdated()) {
    +              // if the segment is updated then get the existing block task id map details
    +              // so that the same can be updated after loading the btree.
    +              if (tableSegmentUniqueIdentifier.isSegmentUpdated()
    +                  && null != segmentTaskIndexWrapper) {
    --- End diff --
    
    double check for tableSegmentUniqueIdentifier.isSegmentUpdated() in above if block and
this if block. Please remove one of them


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message