carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #482: [CARBONDATA-552] Catch the FilterUns...
Date Wed, 04 Jan 2017 13:30:53 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/482#discussion_r94582561
  
    --- Diff: core/src/main/java/org/apache/carbondata/scan/filter/resolver/RowLevelRangeFilterResolverImpl.java
---
    @@ -187,7 +185,11 @@ public void resolve(AbsoluteTableIdentifier absoluteTableIdentifier)
{
               dimColumnEvaluatorInfo.setDimension(columnExpression.getDimension());
               dimColumnEvaluatorInfo.setDimensionExistsInCurrentSilce(false);
               if (columnExpression.getDimension().hasEncoding(Encoding.DIRECT_DICTIONARY))
{
    -            filterInfo.setFilterList(getDirectSurrogateValues(columnExpression));
    +            try {
    +              filterInfo.setFilterList(getDirectSurrogateValues(columnExpression));
    +            } catch (FilterUnsupportedException e) {
    +              FilterUtil.logFilterError(e, false);
    --- End diff --
    
    In the earlier code, if any exception was thrown it was not caught and delegated back
to the caller but that behavior will be changed with this modified code. So in the catch block
please rethrow the exception so that the behavior remains the same as old one


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message