carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #472: [CARBONDATA-568] clean up code for c...
Date Wed, 04 Jan 2017 02:31:54 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/472#discussion_r94521856
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/datastore/chunk/reader/dimension/v2/CompressedDimensionChunkFileBasedReaderV2.java
---
    @@ -135,6 +135,7 @@ public CompressedDimensionChunkFileBasedReaderV2(final BlockletInfo
blockletInfo
           dimensionChunk = fileReader.readByteArray(filePath, dimensionChunksOffset.get(blockIndex),
               dimensionChunksLength.get(blockIndex));
           dimensionColumnChunk = CarbonUtil.readDataChunk(dimensionChunk);
    +      assert dimensionColumnChunk != null;
    --- End diff --
    
    ok. And I found that FileHolder interface is ignoring IOException (catched but just log,
not throwing it). So now I changed FileHolder and the caller to throw IOException


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message