carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #454: [CARBONDATA-484] Implement LRU cache...
Date Mon, 02 Jan 2017 09:36:11 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/454#discussion_r94302586
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/cache/CacheProvider.java ---
    @@ -148,7 +177,11 @@ private boolean dictionaryCacheAlreadyExists(CacheType cacheType)
{
        * Below method will be used to clear the cache
        */
       public void dropAllCache() {
    -    cacheTypeToLRUCacheMap.clear();
    -    cacheTypeToCacheMap.clear();
    +    if(null != carbonLRUCache) {
    +      carbonLRUCache.clear();
    +    }
    +    if(null != cacheTypeToCacheMap) {
    --- End diff --
    
    null check is not required for cacheTypeToCacheMap as it gets initialized when the class
is first refrenced


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message