Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EA786200BEB for ; Wed, 28 Dec 2016 08:55:47 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E8FBE160B2E; Wed, 28 Dec 2016 07:55:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3DDF1160B19 for ; Wed, 28 Dec 2016 08:55:47 +0100 (CET) Received: (qmail 4461 invoked by uid 500); 28 Dec 2016 07:55:46 -0000 Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.incubator.apache.org Delivered-To: mailing list issues@carbondata.incubator.apache.org Received: (qmail 4452 invoked by uid 99); 28 Dec 2016 07:55:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Dec 2016 07:55:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 0C0131A0504 for ; Wed, 28 Dec 2016 07:55:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id mpT7bKSs53qH for ; Wed, 28 Dec 2016 07:55:45 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 166505FADB for ; Wed, 28 Dec 2016 07:55:44 +0000 (UTC) Received: (qmail 3374 invoked by uid 99); 28 Dec 2016 07:55:29 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Dec 2016 07:55:29 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 2CD41DFC47; Wed, 28 Dec 2016 07:55:29 +0000 (UTC) From: chenliang613 To: issues@carbondata.incubator.apache.org Reply-To: issues@carbondata.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-carbondata pull request #473: [CARBONDATA-569] clean up code for c... Content-Type: text/plain Message-Id: <20161228075529.2CD41DFC47@git1-us-west.apache.org> Date: Wed, 28 Dec 2016 07:55:29 +0000 (UTC) archived-at: Wed, 28 Dec 2016 07:55:48 -0000 Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/473#discussion_r94003843 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/GenericDataType.java --- @@ -44,11 +44,6 @@ String getName(); --- End diff -- need delete setName() method also. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---