Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: landreamer <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-450-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-450-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #450: [CARBONDATA-545]Added support for of...
Content-Type: text/plain
Message-Id: <20161225191005.9B9BFDFC47@git1-us-west.apache.org>
Date: Sun, 25 Dec 2016 19:10:05 +0000 (UTC)
archived-at: Sun, 25 Dec 2016 19:10:13 -0000

Github user landreamer commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/450#discussion_r93832426
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/datastore/chunk/DimensionColumnDataChunk.java ---
    @@ -68,17 +78,37 @@ int fillConvertedChunkData(int[] rowMapping, ColumnVectorInfo[] vectorInfo, int
       byte[] getChunkData(int columnIndex);
     
       /**
    -   * Below method will be used get the chunk attributes
    -   *
    -   * @return chunk attributes
    +   * @return inverted index
    +   */
    +  int getInvertedIndex(int index);
    +
    +  /**
    +   * @return whether column is dictionary column or not
    +   */
    +  boolean isNoDicitionaryColumn();
    +
    +  /**
    +   * @return length of each column
        */
    -  DimensionChunkAttributes getAttributes();
    +  int getColumnValueSize();
     
       /**
    -   * Below method will be used to return the complete data chunk
    -   * This will be required during filter query
    +   * @return whether columns where explictly sorted or not
    +   */
    +  boolean isExplictSorted();
    --- End diff --
    
    Does it means "explicit"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---