Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E0C5A200BE3 for ; Thu, 22 Dec 2016 18:50:58 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DF51D160B26; Thu, 22 Dec 2016 17:50:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3682B160B1B for ; Thu, 22 Dec 2016 18:50:58 +0100 (CET) Received: (qmail 41409 invoked by uid 500); 22 Dec 2016 17:50:56 -0000 Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.incubator.apache.org Delivered-To: mailing list issues@carbondata.incubator.apache.org Received: (qmail 41365 invoked by uid 99); 22 Dec 2016 17:50:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Dec 2016 17:50:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2DD0818C367 for ; Thu, 22 Dec 2016 17:50:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.018 X-Spam-Level: X-Spam-Status: No, score=-7.018 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id go32Ek_L2bsK for ; Thu, 22 Dec 2016 17:50:54 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 3854A5FB5D for ; Thu, 22 Dec 2016 17:50:53 +0000 (UTC) Received: (qmail 38664 invoked by uid 99); 22 Dec 2016 17:50:52 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Dec 2016 17:50:52 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 474E7DFBAA; Thu, 22 Dec 2016 17:50:52 +0000 (UTC) From: ravipesala To: issues@carbondata.incubator.apache.org Reply-To: issues@carbondata.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-carbondata pull request #453: [CARBONDATA-549] code improvements f... Content-Type: text/plain Message-Id: <20161222175052.474E7DFBAA@git1-us-west.apache.org> Date: Thu, 22 Dec 2016 17:50:52 +0000 (UTC) archived-at: Thu, 22 Dec 2016 17:50:59 -0000 Github user ravipesala commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/453#discussion_r93667932 --- Diff: core/src/main/java/org/apache/carbondata/core/datastorage/store/compression/WriterCompressModel.java --- @@ -88,15 +88,15 @@ public void setCompType(ValueCompressionUtil.COMPRESSION_TYPE[] compType) { /** * @return the changedDataType --- End diff -- Please change the comment as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---