Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 383B3200BE1 for ; Mon, 19 Dec 2016 14:55:21 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 36DAD160B21; Mon, 19 Dec 2016 13:55:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7F0C8160B18 for ; Mon, 19 Dec 2016 14:55:20 +0100 (CET) Received: (qmail 92719 invoked by uid 500); 19 Dec 2016 13:55:19 -0000 Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.incubator.apache.org Delivered-To: mailing list issues@carbondata.incubator.apache.org Received: (qmail 92710 invoked by uid 99); 19 Dec 2016 13:55:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Dec 2016 13:55:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 54C9618014C for ; Mon, 19 Dec 2016 13:55:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id L1EL1l6Uu61Z for ; Mon, 19 Dec 2016 13:55:18 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id A975C5F365 for ; Mon, 19 Dec 2016 13:55:17 +0000 (UTC) Received: (qmail 92689 invoked by uid 99); 19 Dec 2016 13:55:16 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Dec 2016 13:55:16 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id CDE55DFB77; Mon, 19 Dec 2016 13:55:16 +0000 (UTC) From: jackylk To: issues@carbondata.incubator.apache.org Reply-To: issues@carbondata.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-carbondata issue #445: [CARBONDATA-543] Write unit test cases for ... Content-Type: text/plain Message-Id: <20161219135516.CDE55DFB77@git1-us-west.apache.org> Date: Mon, 19 Dec 2016 13:55:16 +0000 (UTC) archived-at: Mon, 19 Dec 2016 13:55:21 -0000 Github user jackylk commented on the issue: https://github.com/apache/incubator-carbondata/pull/445 I do not think adding unit test for these internal class are good practice, because these class will change easily when adding new features. We should be adding test case for writing and reading CarbonData files (file level features) or loading and query tables (table level features) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---