Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: ravipesala <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-412-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-412-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #412: [CARBONDATA-519]Added vector reader ...
Content-Type: text/plain
Message-Id: <20161216024513.BA85EE040F@git1-us-west.apache.org>
Date: Fri, 16 Dec 2016 02:45:13 +0000 (UTC)
archived-at: Fri, 16 Dec 2016 02:45:19 -0000

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/412#discussion_r92742973
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/CarbonLateDecodeStrategy.scala ---
    @@ -87,19 +90,17 @@ private[sql] class CarbonLateDecodeStrategy extends SparkStrategy {
       private[this] def toCatalystRDD(
           relation: LogicalRelation,
           output: Seq[Attribute],
    -      rdd: RDD[Row],
    +      rdd: RDD[InternalRow],
           needDecode: ArrayBuffer[AttributeReference]):
       RDD[InternalRow] = {
    -    val newRdd = if (needDecode.size > 0) {
    +    if (needDecode.size > 0) {
    +      rdd.asInstanceOf[CarbonScanRDD].setVectorReaderSupport(false)
           getDecoderRDD(relation, needDecode, rdd, output)
    --- End diff --
    
    if vector reader is true and `needDecode.size > 0` then it uses dictionary decoder rdd in its parent.But decoder rdd is not capable of handling columnar batches. 
    I will raise another PR to move the decoder RDD logic to carbon layer. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---