Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: piaoyats <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-412-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-412-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #412: [CARBONDATA-519]Added vector reader ...
Content-Type: text/plain
Message-Id: <20161215023124.25EA8F169E@git1-us-west.apache.org>
Date: Thu, 15 Dec 2016 02:31:24 +0000 (UTC)
archived-at: Thu, 15 Dec 2016 02:31:29 -0000

Github user piaoyats commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/412#discussion_r92533460
  
    --- Diff: core/src/main/java/org/apache/carbondata/scan/executor/QueryExecutorFactory.java ---
    @@ -18,15 +18,69 @@
      */
     package org.apache.carbondata.scan.executor;
     
    +import java.util.List;
    +
    +import org.apache.carbondata.core.carbon.metadata.datatype.DataType;
    +import org.apache.carbondata.core.carbon.metadata.encoder.Encoding;
     import org.apache.carbondata.scan.executor.impl.DetailQueryExecutor;
    +import org.apache.carbondata.scan.executor.impl.VectorDetailQueryExecutor;
    +import org.apache.carbondata.scan.model.QueryDimension;
    +import org.apache.carbondata.scan.model.QueryMeasure;
    +import org.apache.carbondata.scan.model.QueryModel;
    +import org.apache.carbondata.scan.result.vector.CarbonColumnVector;
    +import org.apache.carbondata.scan.result.vector.CarbonColumnarBatch;
    +import org.apache.carbondata.scan.result.vector.impl.CarbonColumnVectorImpl;
     
     /**
      * Factory class to get the query executor from RDD
      * This will return the executor based on query type
      */
     public class QueryExecutorFactory {
     
    -  public static QueryExecutor getQueryExecutor() {
    -    return new DetailQueryExecutor();
    +  public static QueryExecutor getQueryExecutor(QueryModel queryModel) {
    +    if (queryModel.isVectorReader()) {
    +      return new VectorDetailQueryExecutor();
    +    } else {
    +      return new DetailQueryExecutor();
    +    }
    +  }
    +
    +  public static CarbonColumnarBatch createColuminarBatch(QueryModel queryModel) {
    +    int batchSize = 10000;
    --- End diff --
    
    Can we set batchSize through configuration? which is useful for tuning.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---